ACP endpoints carry no hand-authored SKILL.md — they wrap an + * external coding-agent CLI rather than a skill package. Without a + * synthesized body, an agent that calls + * {@code readSkillFile(skillName=..., filePath="SKILL.md")} gets + * nothing beyond the one-line description and cannot tell how to + * drive the endpoint. + * + *
This builds a markdown brief from the live endpoint row: what
+ * the endpoint is, the single wrapper tool it exposes, that tool's
+ * arguments, and usage notes — so the LLM can call
+ * {@code acp_ Without a body, an agent calling
+ * {@code readSkillFile(filePath="SKILL.md")} on an ACP endpoint gets
+ * "Error: SKILL.md content not available" and has nothing beyond the
+ * one-line description to work from.
+ */
+class AcpSkillBridgeContentTest {
+
+ private AcpEndpointService endpointService;
+ private AcpSkillBridge bridge;
+
+ @BeforeEach
+ void setUp() {
+ endpointService = mock(AcpEndpointService.class);
+ AcpDelegationService delegationService = mock(AcpDelegationService.class);
+ ToolRegistry toolRegistry = mock(ToolRegistry.class);
+ bridge = new AcpSkillBridge(endpointService, delegationService, new ObjectMapper(), toolRegistry);
+ }
+
+ @Test
+ @DisplayName("ResolvedSkill carries a synthesized SKILL.md body, not an empty string")
+ void resolvedSkillHasNonEmptyContent() {
+ AcpEndpointEntity ep = newEndpoint(7L, "codex");
+ ep.setDescription("OpenAI-compatible coding agent");
+ when(endpointService.listEnabled()).thenReturn(List.of(ep));
+
+ ResolvedSkill resolved = bridge.listAcpDerivedResolvedSkills().get(0);
+
+ assertNotNull(resolved.getContent());
+ assertFalse(resolved.getContent().isBlank(), "SKILL.md body must not be blank");
+ String body = resolved.getContent();
+ assertTrue(body.contains("# codex"), "expected a markdown title, got: " + body);
+ assertTrue(body.contains("OpenAI-compatible coding agent"),
+ "expected the endpoint description in the body, got: " + body);
+ assertTrue(body.contains("acp_codex_prompt"),
+ "expected the wrapper tool name in the body, got: " + body);
+ assertTrue(body.contains("`prompt`") && body.contains("`cwd`"),
+ "expected both wrapper parameters documented, got: " + body);
+ assertTrue(body.contains("## Usage notes"),
+ "expected a usage notes section, got: " + body);
+ }
+
+ @Test
+ @DisplayName("virtual SkillEntity skillContent matches the ResolvedSkill content")
+ void skillEntityContentMatchesResolved() {
+ AcpEndpointEntity ep = newEndpoint(7L, "codex");
+ when(endpointService.listEnabled()).thenReturn(List.of(ep));
+
+ SkillEntity entity = bridge.listAcpDerivedSkillEntities().get(0);
+ ResolvedSkill resolved = bridge.listAcpDerivedResolvedSkills().get(0);
+
+ assertNotNull(entity.getSkillContent());
+ assertFalse(entity.getSkillContent().isBlank(), "skillContent must not be blank");
+ assertEquals(resolved.getContent(), entity.getSkillContent(),
+ "entity skillContent and resolved content must be the same synthesized body");
+ }
+
+ @Test
+ @DisplayName("trusted endpoints document the no-approval behavior")
+ void trustedEndpointPhrasing() {
+ AcpEndpointEntity ep = newEndpoint(7L, "codex");
+ ep.setTrusted(true);
+ when(endpointService.listEnabled()).thenReturn(List.of(ep));
+
+ String body = bridge.listAcpDerivedResolvedSkills().get(0).getContent();
+
+ assertTrue(body.contains("trusted: the agent's own tool calls are accepted"),
+ "expected trusted phrasing, got: " + body);
+ }
+
+ @Test
+ @DisplayName("untrusted endpoints document that tool calls may need approval")
+ void untrustedEndpointPhrasing() {
+ AcpEndpointEntity ep = newEndpoint(7L, "codex");
+ ep.setTrusted(false);
+ when(endpointService.listEnabled()).thenReturn(List.of(ep));
+
+ String body = bridge.listAcpDerivedResolvedSkills().get(0).getContent();
+
+ assertTrue(body.contains("not trusted: the agent's tool calls may require"),
+ "expected untrusted phrasing, got: " + body);
+ }
+
+ @Test
+ @DisplayName("status hint reflects a failed connection test")
+ void erroredEndpointStatusHint() {
+ AcpEndpointEntity ep = newEndpoint(7L, "codex");
+ ep.setLastStatus("ERROR");
+ ep.setLastError("command not found: codex");
+ when(endpointService.listEnabled()).thenReturn(List.of(ep));
+
+ String body = bridge.listAcpDerivedResolvedSkills().get(0).getContent();
+
+ assertTrue(body.contains("Last connection test failed: command not found: codex"),
+ "expected the error surfaced in the body, got: " + body);
+ }
+
+ @Test
+ @DisplayName("status hint reflects an OK connection test")
+ void okEndpointStatusHint() {
+ AcpEndpointEntity ep = newEndpoint(7L, "codex");
+ ep.setLastStatus("OK");
+ when(endpointService.listEnabled()).thenReturn(List.of(ep));
+
+ String body = bridge.listAcpDerivedResolvedSkills().get(0).getContent();
+
+ assertTrue(body.contains("Last connection test: OK."),
+ "expected OK status in the body, got: " + body);
+ }
+
+ @Test
+ @DisplayName("untested endpoints note the CLI is spawned on first call")
+ void untestedEndpointStatusHint() {
+ AcpEndpointEntity ep = newEndpoint(7L, "codex");
+ ep.setLastStatus("UNKNOWN");
+ when(endpointService.listEnabled()).thenReturn(List.of(ep));
+
+ String body = bridge.listAcpDerivedResolvedSkills().get(0).getContent();
+
+ assertTrue(body.contains("Not yet tested"),
+ "expected an untested hint, got: " + body);
+ }
+
+ @Test
+ @DisplayName("CJK-only endpoint names slug to a stable id-based wrapper tool name")
+ void cjkOnlyNameUsesIdSlugInContent() {
+ AcpEndpointEntity ep = newEndpoint(42L, "代码助手");
+ when(endpointService.listEnabled()).thenReturn(List.of(ep));
+
+ String body = bridge.listAcpDerivedResolvedSkills().get(0).getContent();
+
+ assertTrue(body.contains("acp_acp-42_prompt"),
+ "all-CJK name should fall back to an id-based wrapper name, got: " + body);
+ }
+
+ @Test
+ @DisplayName("findResolvedById and findEntityById return entries with the synthesized body")
+ void lookupByVirtualIdCarriesContent() {
+ AcpEndpointEntity ep = newEndpoint(7L, "codex");
+ when(endpointService.get(7L)).thenReturn(ep);
+
+ long virtualId = AcpSkillBridge.virtualIdFor(ep);
+ ResolvedSkill resolved = bridge.findResolvedById(virtualId);
+ SkillEntity entity = bridge.findEntityById(virtualId);
+
+ assertNotNull(resolved);
+ assertNotNull(entity);
+ assertFalse(resolved.getContent().isBlank(), "resolved content must not be blank");
+ assertFalse(entity.getSkillContent().isBlank(), "entity skillContent must not be blank");
+ }
+
+ private static AcpEndpointEntity newEndpoint(long id, String name) {
+ AcpEndpointEntity ep = new AcpEndpointEntity();
+ ep.setId(id);
+ ep.setName(name);
+ ep.setEnabled(true);
+ ep.setCommand("codex");
+ return ep;
+ }
+}