opensource/mateclaw
2
0
Fork 0
mirror of https://gitee.com/mateos/mateclaw.git synced 2026-09-15 03:55:09 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor(wiki): drop ineffective @Transactional on self-invoked scan-update methods

Browse Source 
updateTextContentFromScan / updateBinaryFileFromScan are only reached via
self-invocation from the ingest* methods, so the proxy-based @Transactional
never applied. Each runs a single atomic updateById; remove the misleading
annotation and document why.
This commit is contained in:
matevip 2026-06-07 19:53:12 +08:00
parent d3a432d8e3
commit f238959856
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mateclaw-server/src/main/java/vip/mate/wiki/service/WikiRawMaterialService.java
View File

@ -136,8 +136,12 @@ public class WikiRawMaterialService {
* Update an existing text raw in-place when a directory-scanned file has changed content. * Update an existing text raw in-place when a directory-scanned file has changed content.
* Resets processing state and triggers re-processing so new pages are generated from the * Resets processing state and triggers re-processing so new pages are generated from the
* updated content without leaving a stale duplicate row alongside the new one. * updated content without leaving a stale duplicate row alongside the new one.
*
* <p>No {@code @Transactional}: this runs a single atomic {@code updateById} and is only
* reached via self-invocation from {@code ingestTextFileFromScan}, where the annotation
* would be bypassed by the proxy anyway. The re-processing event is published after the
* row is persisted so the async listener reads committed state.
*/ */
@Transactional
public void updateTextContentFromScan(Long rawId, String title, String content, String sourcePath) { public void updateTextContentFromScan(Long rawId, String title, String content, String sourcePath) {
WikiRawMaterialEntity entity = rawMapper.selectById(rawId); WikiRawMaterialEntity entity = rawMapper.selectById(rawId);
if (entity == null) return; if (entity == null) return;
@ -211,8 +215,11 @@ public class WikiRawMaterialService {
/** /**
* Update an existing binary raw in-place when a directory-scanned file has changed content. * Update an existing binary raw in-place when a directory-scanned file has changed content.
*
* <p>No {@code @Transactional}: single atomic {@code updateById} reached only via
* self-invocation from {@code ingestBinaryFileFromScan} (proxy bypassed); the re-processing
* event is published after the row is persisted.
*/ */
@Transactional
public void updateBinaryFileFromScan(Long rawId, String sourcePath, long fileSize, String hash) { public void updateBinaryFileFromScan(Long rawId, String sourcePath, long fileSize, String hash) {
WikiRawMaterialEntity entity = rawMapper.selectById(rawId); WikiRawMaterialEntity entity = rawMapper.selectById(rawId);
if (entity == null) return; if (entity == null) return;