2 Commits

Author	SHA1	Message	Date
matevip	b4697f2806	fix(cron): post-deploy bug bundle — flakiness, scheduler, channel UI ... User-reported field issues + a deeper code audit revealed multiple overlapping bugs in the prior cron-channel delivery change. This fixes all six. #1 — Concurrency race on ToolExecutionExecutor (root cause of 'sometimes succeeds, sometimes fails' tool calls). The volatile instance fields currentRequesterId / currentWorkspaceBasePath / currentChatOrigin were shared by every conversation routed through the same per-agent executor; one user mid-build-loop while another's execute() overwrote the field would cross-contaminate the captured values into PreparedToolCall. Fix: kill the instance fields, thread origin/requester/workspace as method params straight into PreparedToolCall snapshot. Comment pins the rule so it cannot regress. #2 — CHAT_ORIGIN missing from KeyStrategyFactory (latent timebomb, masked by spring-ai-alibaba-graph-core's non-filtering builder path). Without an addStrategy registration, multi-node state merges in long ReAct / Plan-Execute loops drop the key, ActionNode reads ChatOrigin.EMPTY, and the cron persists with channel_id=NULL. Also caught 4 more keys that were latently unregistered: WORKSPACE_BASE_PATH, STOP_REQUESTED, RETURN_DIRECT_TRIGGERED, DIRECT_TOOL_OUTPUTS. All five now registered in both ReAct and Plan-Execute factories. #3 — CronJobs UI didn't surface channel binding. CronJobDTO carried channelId / deliveryConfig but the list page never rendered them. Added: (a) 'channel' column on list page, (b) channel + targetId rows in the detail modal, (c) backend batch-loads channel names via ChannelMapper.selectBatchIds so the column shows the human-readable name, (d) i18n keys (zh + en), (e) channelName field on TS CronJob type. #4a — DingTalk targetId expiry. ChannelChatOriginFactory.resolveTargetId used to prefer ChannelMessage.replyToken which for DingTalk encodes a sessionWebhook URL that expires ~90 minutes after the inbound message. Cron persisted with that webhook then dies with 401/403 and marks NOT_DELIVERED forever. Fix: prefer the stable chatId, fall back to senderId — both work indefinitely via DingTalk's Robot API. #4b — Scheduler pool exhaustion under long LLM. CronJobService's ThreadPoolTaskScheduler ran with poolSize=4 AND the LLM call lived on the scheduler thread. Four concurrent crons saturated the pool and the 5th silently missed its tick. Fix: keep scheduler tiny (it just fires triggers) and offload runAgent to a dedicated virtual-thread executor (cron-execute-* threads). LLM workload is I/O-bound — virtual threads scale to thousands at trivial cost. #5 — Minor latent bugs: - AbstractCronResultDelivery.claimRun used .in(... 'NONE','PENDING',null), but SQL IN never matches NULL. Rewrote as IS NULL OR IN (NONE,PENDING) so legacy pre-V57 rows can still claim. - CronDeliveryListener.onCompletedRaw was an empty @EventListener with a wrong-headed comment about test fallbackExecution. Removed. - CronJobTool.resolveAgentId silently returned 1L when origin lacked an agentId — would silently bind to whatever agent #1 happens to be. Replaced with explicit error so wiring bugs surface immediately instead of producing scheduled-but-never-runs crons. State-key registration guard. New StateKeyRegistrationCoverageTest scans MateClawStateKeys via reflection and parses AgentGraphBuilder.java to extract every .addStrategy(MateClawStateKeys.X, ...). Asserts every non-_NODE constant appears in at least one factory. Caught the 4 unregistered keys above on first run; will catch any future 'forgot to register' regression. Tests: 33 unit/arch tests + 27 regression in touched areas — all green. Vue typecheck clean. Refs: #25, #16	2026-04-28 21:45:07 +08:00
matevip	4011050ceb	feat(cron): channel delivery via ChatOrigin + Spring AI ToolContext ... Replaces the prior ThreadLocal context plumbing with explicit Spring AI ToolContext threading carried by an immutable ChatOrigin value object, so a cron created from inside WeChat (or any IM channel) delivers its results back to the originating channel. Architecture - ChatOrigin / ChannelTarget value objects + per-entry-point factories (ChannelChatOriginFactory in vip.mate.channel, CronChatOriginFactory in vip.mate.cron — symmetric, no cyclic deps). - LocaleAwareToolCallback now forwards call(String, ToolContext) and getToolMetadata so the decorator chain cannot silently drop the origin. - AgentService 6-method overhaul + ChatOriginHolder bridge into StateGraph buildInitialState which writes CHAT_ORIGIN; ActionNode + StepExecutionNode forward it to ToolExecutionExecutor. - ToolExecutionExecutor builds ToolContext per call; 8/8 tools migrated (CronJobTool, WorkspacePathGuard, Video/Image/Browser/ReadFile/Music, DelegateAgentTool with parent-origin inheritance). - CronJobRunner + CronJobLifecycleService 3-segment REQUIRES_NEW model (T1 startRun / no-tx runAgent / T2 finishRunAndPublish); ArchUnit pins CronJobRunner as @Transactional-free. - CronResultDelivery Strategy + AbstractCronResultDelivery Template with SQL CAS idempotency on mate_cron_job_run.delivery_status — replaces the prior process-local Caffeine TTL, cluster-safe. - CronJobCompletedEvent + @Async @TransactionalEventListener(AFTER_COMMIT); cronDeliveryExecutor (core=2, max=4, queue=1000, AbortPolicy + audit). - CronRunStaleCleanup @Scheduled(5min) sweeps PENDING-15min and status='running'-30min in one query each. - CronJobRunner.wrapWithDeliveryGuard prepends a system note for channel-bound crons to suppress hallucinated 'install CLI to send WeChat' suggestions. - ApprovalWorkflowService Memento: persist ChatOrigin snapshot on create, restore on replay so cross-restart approvals keep channel binding; ChannelMessageRouter + ChatController web-replay both prefer the Memento and fall back to fresh-build. - ChannelManager.sendToChannel 4-arg DeliveryOptions overload; ChannelAdapter#proactiveSend default 4-arg pass-through; Slack overrides for thread_ts and Telegram overrides for message_thread_id. - CronJobs UI: read-only 'last delivery' badge driven by CronJobMapper.selectListWithDeliveryStatus subquery. Schema migrations V57/V58/V59 (V56 was already taken by an unrelated provider migration — Flyway processes versions in order regardless of gaps): - V57: mate_cron_job_run delivery_status / target / error + composite index (delivery_status, started_at) covering the cleanup sweep. - V58: mate_cron_job channel_id (indexed) + delivery_config TEXT (JSON via MyBatis Plus JacksonTypeHandler). - V59: mate_tool_approval chat_origin TEXT (Memento). All idempotent in both H2 (IF NOT EXISTS) and MySQL (INFORMATION_SCHEMA guard + PREPARE). ArchUnit guards (test scope, archunit-junit5 1.3.0): - every concrete vip.mate.* ToolCallback must override call(String, ToolContext) — pins the decorator-forward fix. - CronJobRunner must NOT carry @Transactional on the class or any method — pins the 3-segment lifecycle rule. Tests: 32 new unit tests + 21 regression tests in touched areas, all 53 green: - ChatOriginTest (6) — value-object invariants + JSON round-trip. - LocaleAwareToolCallbackToolContextTest (2) — decorator forward. - DeliveryConfigTest (4) — Jackson round-trip + forward-compat. - ToolCallbackToolContextForwardArchTest (2) — both ArchUnit guards. - CronJobRunnerDeliveryGuardTest (3) — channel-cron prefix injection. - AbstractCronResultDeliveryTest (4) — claim CAS + concurrent CAS. - ChannelCronResultDeliveryTest (6) — supports / doDeliver / errors. - ApprovalReplayContinuityTest (5) — Memento round-trip + corrupt payload fallback + unknown-field tolerance. Refs: #25, #16	2026-04-28 21:43:58 +08:00