opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-09-08 11:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): remove knowledge sidebar retrieval mode

Browse Source
This commit is contained in:
Stephen Zhou 2026-08-18 15:20:33 +08:00
parent 78800993e2
commit b95d0f4743
No known key found for this signature in database
2 changed files with 4 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
web/features/new-rag/__tests__/knowledge-space-shell.spec.tsx
View File

@ -188,7 +188,9 @@ describe('KnowledgeSpaceShell', () => {
)
expect(screen.getByRole('heading', { name: 'Support knowledge' })).toBeInTheDocument()
expect(screen.getByText('dataset.newKnowledge.settings.retrievalMode.fast')).toBeInTheDocument()
expect(
screen.queryByText('dataset.newKnowledge.settings.retrievalMode.fast'),
).not.toBeInTheDocument()
expect(screen.queryByText('text-embedding-3-large')).not.toBeInTheDocument()
expect(screen.getByRole('link', { name: 'common.mainNav.home' })).toHaveAttribute('href', '/')
expect(screen.getByRole('link', { name: 'dataset.knowledge' })).toHaveAttribute(
@ -269,20 +271,6 @@ describe('KnowledgeSpaceShell', () => {
)
})
it('does not invent sidebar metadata when the summary profile is unavailable', () => {
queryMock.data = {
control_space_id: 'space-1',
state: 'active',
technical_summary: { name: 'Support knowledge' },
}
render(<KnowledgeSpaceShell knowledgeSpaceId="space-1">source content</KnowledgeSpaceShell>)
expect(
screen.queryByText('dataset.newKnowledge.settings.retrievalMode.fast'),
).not.toBeInTheDocument()
})
it('marks settings as the current navigation item', () => {
pathnameMock.value = '/datasets/new/space-1/settings'
queryMock.data = {

43
web/features/new-rag/knowledge-space-shell.tsx
View File

@ -36,38 +36,6 @@ function responseStatus(error: unknown) {
}
}
function recordProperty(value: unknown, key: string) {
if (!value || typeof value !== 'object' || Array.isArray(value)) return
const property = (value as Record<string, unknown>)[key]
if (!property || typeof property !== 'object' || Array.isArray(property)) return
return property as Record<string, unknown>
}
function stringProperty(value: unknown, ...keys: string[]) {
if (!value || typeof value !== 'object' || Array.isArray(value)) return
for (const key of keys) {
const property = (value as Record<string, unknown>)[key]
if (typeof property === 'string' && property.length > 0) return property
}
}
function retrievalModeFromProfile(modelProfile: unknown) {
const pendingConfiguration =
recordProperty(modelProfile, 'pendingModelConfiguration') ??
recordProperty(modelProfile, 'pending_model_configuration')
const retrievalProfile =
recordProperty(modelProfile, 'retrievalProfile') ??
recordProperty(modelProfile, 'retrieval_profile') ??
recordProperty(pendingConfiguration, 'retrievalProfile') ??
recordProperty(pendingConfiguration, 'retrieval_profile')
const mode = stringProperty(retrievalProfile, 'defaultMode', 'default_mode')
if (mode === 'deep' || mode === 'fast' || mode === 'research') return mode
}
const knowledgeSpacePageTitle = (
pathname: string,
t: ReturnType<typeof useTranslation<'dataset'>>['t'],
@ -139,8 +107,6 @@ export function KnowledgeSpaceShell({
externalAccessQuery.data.agent_enabled === true
const knowledgeSpaceName =
knowledgeSpaceQuery.data?.technical_summary?.name ?? t(($) => $.knowledge)
const modelProfile = knowledgeSpaceQuery.data?.technical_summary?.model_profile
const retrievalMode = retrievalModeFromProfile(modelProfile)
const pageTitle = knowledgeSpacePageTitle(pathname, t, tCommon)
const documentTitle = `${pageTitle} · ${knowledgeSpaceName}`
const documentTitleOwnedByChild =
@ -296,17 +262,10 @@ export function KnowledgeSpaceShell({
size="medium"
/>
{sidebarExpanded && (
<div className="flex min-w-0 flex-1 flex-col gap-0.5">
<div className="flex min-w-0 flex-1">
<h1 className="truncate system-md-semibold text-text-secondary">
{knowledgeSpaceName}
</h1>
{retrievalMode && (
<div className="flex min-w-0 items-center gap-2 system-2xs-medium-uppercase text-text-tertiary">
<span className="truncate">
{t(($) => $[`newKnowledge.settings.retrievalMode.${retrievalMode}`])}
</span>
</div>
)}
</div>
)}
</div>