opensource/mateclaw
2
0
Fork 0
mirror of https://gitee.com/mateos/mateclaw.git synced 2026-09-15 03:55:09 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(agent): align skill tool whitelist with real @Tool method names + restore globally-promised tools

Browse Source
This commit is contained in:
matevip 2026-05-01 20:14:56 +08:00
parent 888200e1cd
commit 3d0797787b
1 changed files with 46 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
mateclaw-server/src/main/java/vip/mate/agent/binding/service/AgentBindingService.java
View File

@ -228,25 +228,41 @@ public class AgentBindingService {
* {@link #getEffectiveToolNames} allowlist completely. * {@link #getEffectiveToolNames} allowlist completely.
*/ */
private static final Set<String> SYSTEM_LEVEL_TOOLS = Set.of( private static final Set<String> SYSTEM_LEVEL_TOOLS = Set.of(
// Memory write/read primitives — every agent needs these // Structured memory primitives — used by every agent regardless
// regardless of skill bindings, otherwise the self-evolution // of skill bindings, otherwise the self-evolution path collapses
// path collapses (§11.3 / §11.4). // (§11.3 / §11.4).
"record_lesson", "record_lesson",
"remember", "remember",
"remember_structured", "remember_structured",
"recall_structured", "recall_structured",
"forget_structured", "forget_structured",
// Workspace memory file CRUD (PROFILE.md / MEMORY.md / SOUL.md) // Workspace memory file CRUD (PROFILE.md / MEMORY.md / SOUL.md /
"read_workspace_file", // memory/YYYY-MM-DD.md). Prior versions whitelisted
"write_workspace_file", // "read_workspace_file" / "write_workspace_file" /
"list_workspace_files", // "list_workspace_files" — those names match no @Tool bean; the
// actual function names carry the "_memory" segment, so the
// earlier carve-out was silently dead.
"list_workspace_memory_files",
"read_workspace_memory_file",
"write_workspace_memory_file",
"edit_workspace_memory_file",
// Skill discovery / dispatch — skills are docs, not callables; // Skill discovery / dispatch — skills are docs, not callables;
// these helpers let the LLM read SKILL.md / run scripts. // these helpers let the LLM read SKILL.md / run scripts.
"readSkillFile", "readSkillFile",
"runSkillScript", "runSkillScript",
// Date/time + delegate — fundamental cross-skill utilities "listSkillFiles",
"datetime", "listAvailableSkills",
"delegate_agent", // Date / time — prior whitelist had a fictional "datetime"; the
// real DateTimeTool exposes three separate methods.
"getCurrentDate",
"getCurrentDateTime",
"getCurrentTime",
// Multi-agent delegation — prior whitelist had "delegate_agent",
// but DelegateAgentTool's @Tool methods are delegateToAgent /
// delegateParallel / listAvailableAgents. Same dead-name bug.
"delegateToAgent",
"delegateParallel",
"listAvailableAgents",
// Document / media generation — agent-wide capabilities, never // Document / media generation — agent-wide capabilities, never
// declared inside any skill manifest. Pre-Phase-2b these were // declared inside any skill manifest. Pre-Phase-2b these were
// universally visible; the new gate silently strips them whenever // universally visible; the new gate silently strips them whenever
@ -260,7 +276,26 @@ public class AgentBindingService {
"renderDocxFromFiles", "renderDocxFromFiles",
"image_generate", "image_generate",
"music_generate", "music_generate",
"video_generate" "video_generate",
// Universal capabilities the global system prompts (SOUL.md /
// AGENTS.md / "Web Search Capability" / "File Reading Guidelines")
// explicitly tell the LLM exist. Pre-Phase-2b they were globally
// available; the new gate silently hid them on any agent with
// skills bound, so the prompt promises a tool the registry then
// refuses ("Tool not found: search"). Observed 2026-05-01 on the
// Code Reviewer agent — the model called search → got
// not-found → gave up before ever reaching renderDocx.
"search",
"browser_use",
"read_file",
"write_file",
"edit_file",
"execute_shell_command",
"detect_file_type",
"extract_document_text",
"extract_pdf_text",
"extract_docx_text",
"readMateClawDoc"
); );
private ResolvedSkill findResolvedSkillById(Long skillId) { private ResolvedSkill findResolvedSkillById(Long skillId) {