opensource/mateclaw
2
0
Fork 0
mirror of https://gitee.com/mateos/mateclaw.git synced 2026-09-13 03:13:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

test(memory,wecom): align two stale tests with current production behavior

Browse Source 
Both failed on dev independently of the recent merges (confirmed against a
pre-merge baseline):

- MemorySummarizationStructuredRoutingTest reflected applyStructuredEntries by
  its old (Long, JsonNode) signature; owner-isolation added a trailing ownerKey
  param. Update the reflective lookup to (Long, JsonNode, String) and the
  remember() verifications to the 6-arg overload.

- ToolGuardCardHandlerTest still asserted the old 'system-owned pending accepts
  any clicker' behavior, but the handler now rejects a group click on a
  system/cron-owned approval fail-closed (no human requester to match), routing
  it to the admin console. Assert no synthetic injection + the unauthorized card
  render instead.
This commit is contained in:
matevip 2026-06-09 10:15:22 +08:00
parent 3209868274
commit f699746d65
2 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mateclaw-server/src/test/java/vip/mate/channel/wecom/cards/tool_guard/ToolGuardCardHandlerTest.java
View File

@ -130,8 +130,8 @@ class ToolGuardCardHandlerTest {
}
@Test
@DisplayName("system-owned pending allows ANY clicker (no original requester)")
void systemPendingAcceptsAnyClicker() {
@DisplayName("system-owned pending rejects a group clicker (fail-closed → admin console)")
void systemPendingRejectsGroupClicker() {
PendingApproval pending = pendingFor("pid_sys", "system", "shell_exec");
when(approvalService.getPending("pid_sys")).thenReturn(Optional.of(pending));
@ -139,7 +139,11 @@ class ToolGuardCardHandlerTest {
ToolGuardButtonKey.Action.APPROVE, "pid_sys", "shell_exec", "MEDIUM"));
handler.handle(adapter, frame, tce(frame), fromBlock("anyone"));
verify(adapter).injectSyntheticMessage(any(ChannelMessage.class));
// A "system"/cron-owned approval has no human requester to match the
// clicker against, so a group button click is rejected (fail-closed) and
// never injected for execution — these resolve through the admin console.
verify(adapter, never()).injectSyntheticMessage(any(ChannelMessage.class));
verify(adapter).updateTemplateCard(eq("evt_req_5"), any());
}
@Test

23
mateclaw-server/src/test/java/vip/mate/memory/service/MemorySummarizationStructuredRoutingTest.java
View File

@ -36,12 +36,13 @@ class MemorySummarizationStructuredRoutingTest {
structured);
}
private void invokeApply(MemorySummarizationService svc, long agentId, String entriesJson) throws Exception {
private void invokeApply(MemorySummarizationService svc, long agentId, String ownerKey, String entriesJson)
throws Exception {
JsonNode node = mapper.readTree(entriesJson);
Method m = MemorySummarizationService.class
.getDeclaredMethod("applyStructuredEntries", Long.class, JsonNode.class);
.getDeclaredMethod("applyStructuredEntries", Long.class, JsonNode.class, String.class);
m.setAccessible(true);
m.invoke(svc, agentId, node);
m.invoke(svc, agentId, node, ownerKey);
}
@Test
@ -50,15 +51,15 @@ class MemorySummarizationStructuredRoutingTest {
StructuredMemoryService structured = mock(StructuredMemoryService.class);
MemorySummarizationService svc = newService(structured);
invokeApply(svc, 1000000001L, """
invokeApply(svc, 1000000001L, "owner-1", """
[
{"type": "project", "key": "project_codename", "content": "项目代号：云梯计划"},
{"type": "user", "key": "preferred_output_format", "content": "偏好表格输出"}
]
""");
verify(structured).remember(1000000001L, "project", "project_codename", "项目代号：云梯计划", "auto-summary");
verify(structured).remember(1000000001L, "user", "preferred_output_format", "偏好表格输出", "auto-summary");
verify(structured).remember(1000000001L, "project", "project_codename", "项目代号：云梯计划", "auto-summary", "owner-1");
verify(structured).remember(1000000001L, "user", "preferred_output_format", "偏好表格输出", "auto-summary", "owner-1");
verifyNoMoreInteractions(structured);
}
@ -68,7 +69,7 @@ class MemorySummarizationStructuredRoutingTest {
StructuredMemoryService structured = mock(StructuredMemoryService.class);
MemorySummarizationService svc = newService(structured);
invokeApply(svc, 1000000001L, """
invokeApply(svc, 1000000001L, "owner-1", """
[
{"type": "secret", "key": "k", "content": "bad type"},
{"type": "project", "key": "", "content": "missing key"},
@ -78,7 +79,7 @@ class MemorySummarizationStructuredRoutingTest {
""");
// Only the last, fully-valid entry is written.
verify(structured).remember(1000000001L, "project", "good", "kept", "auto-summary");
verify(structured).remember(1000000001L, "project", "good", "kept", "auto-summary", "owner-1");
verifyNoMoreInteractions(structured);
}
@ -88,9 +89,9 @@ class MemorySummarizationStructuredRoutingTest {
StructuredMemoryService structured = mock(StructuredMemoryService.class);
MemorySummarizationService svc = newService(structured);
invokeApply(svc, 1000000001L, "null");
invokeApply(svc, 1000000001L, "\"not-an-array\"");
invokeApply(svc, 1000000001L, "[]");
invokeApply(svc, 1000000001L, "owner-1", "null");
invokeApply(svc, 1000000001L, "owner-1", "\"not-an-array\"");
invokeApply(svc, 1000000001L, "owner-1", "[]");
verifyNoInteractions(structured);
}